Fix AttributeError when Eleven Labs API key is not set#1238
Open
majiayu000 wants to merge 1 commit intokhoj-ai:masterfrom
Open
Fix AttributeError when Eleven Labs API key is not set#1238majiayu000 wants to merge 1 commit intokhoj-ai:masterfrom
majiayu000 wants to merge 1 commit intokhoj-ai:masterfrom
Conversation
When ELEVEN_LABS_API_KEY is not configured, generate_text_to_speech was returning a string instead of a Response object, causing AttributeError: 'str' object has no attribute 'iter_content'. This fix: - Introduces TextToSpeechError exception class - Raises exception instead of returning error string - API endpoint catches the exception and returns HTTP 501 Fixes khoj-ai#1049 Signed-off-by: majiayu000 <1835304752@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ELEVEN_LABS_API_KEYis not configured, the function was returning a string instead of a Response objectChanges
TextToSpeechErrorexception class intext_to_speech.pygenerate_text_to_speechto raise exception instead of returning error stringTest plan
Fixes #1049